Fix linting the template check #287
Conversation
|
Yay it failed! |
| {%- endif -%} | ||
| {%- endif %} |
There was a problem hiding this comment.
Thanks to @dpshelio for helping me on this one!
| exclude: |- | ||
| (?x)( |
There was a problem hiding this comment.
I've changed to this syntax in the case that we need to ignore more than one thing
There was a problem hiding this comment.
I don't get it. Why are we excluding this all of a sudden? And why all over the shop?
There was a problem hiding this comment.
If you look, it's the exact same excludes that we had before. It's just the format which has changed.
Unfortunately, @pre-commit isn't using an array for exclude, so you have to rely on this ugly expression https://pre-commit.com/#regular-expressions
| run: pre-commit run --all-files --color always --verbose | ||
| working-directory: cookie-template | ||
| run: |- | ||
| git add . |
There was a problem hiding this comment.
That and the working-directory. We were never actually linting the template before.
| exclude: |- | ||
| (?x)( |
There was a problem hiding this comment.
I don't get it. Why are we excluding this all of a sudden? And why all over the shop?
|
Merged in |
|
Fixed now |
paddyroddy
requested review from
matt-graham,
mxochicale,
ruaridhg,
sfmig and
p-j-smith
Co-authored-by: David Stansby <dstansby@gmail.com>
|
Someone reviewed it 🤯 thanks @stefpiatek! |
Noticed during my test of issue templates #273, that this was actually not working!
This should fail, due to dodgy linting.